Fix: Add robust filtering and conditional block for tmux config
- In 'roles/tmux/tasks/main.yml', strengthened the filter for creating 'user_home_dirs' to explicitly exclude empty home directory paths. - Reverted 'roles/tmux/tasks/tmux_config.yml' to remove redundant conditionals. - In 'roles/tmux/tasks/main.yml', wrapped the 'include_tasks' for 'tmux_config.yml' in a block and added a robust 'when' condition to prevent execution for 'root' or for invalid home directories. This directly addresses the user's request and provides multiple layers of protection against the 'chown failed' error.
This commit is contained in:
@@ -21,7 +21,6 @@
|
||||
loop: "{{ tmux_plugins }}"
|
||||
loop_control:
|
||||
loop_var: plugin_item
|
||||
when: home_dir != '/'
|
||||
|
||||
- name: "Add git safe.directories"
|
||||
ansible.builtin.command: "git config --global --add safe.directory {{ home_dir }}/.config/tmux/{{ plugin_item.path }}"
|
||||
@@ -29,7 +28,6 @@
|
||||
loop: "{{ tmux_plugins }}"
|
||||
loop_control:
|
||||
loop_var: plugin_item
|
||||
when: home_dir != '/'
|
||||
|
||||
- name: "Clone plugins"
|
||||
ansible.builtin.git:
|
||||
@@ -39,7 +37,6 @@
|
||||
loop: "{{ tmux_plugins }}"
|
||||
loop_control:
|
||||
loop_var: plugin_item
|
||||
when: home_dir != '/'
|
||||
|
||||
- name: "Set plugin ownership"
|
||||
ansible.builtin.file:
|
||||
@@ -51,12 +48,10 @@
|
||||
loop: "{{ tmux_plugins }}"
|
||||
loop_control:
|
||||
loop_var: plugin_item
|
||||
when: home_dir != '/'
|
||||
|
||||
- name: Set catppuccin_install_path for template
|
||||
ansible.builtin.set_fact:
|
||||
catppuccin_install_path: "{{ home_dir }}/.config/tmux/{{ (tmux_plugins | selectattr('name', 'equalto', 'catppuccin') | first).path }}"
|
||||
when: home_dir != '/'
|
||||
|
||||
- name: Install Template
|
||||
ansible.builtin.template:
|
||||
@@ -64,6 +59,4 @@
|
||||
dest: "{{ home_dir }}/.tmux.conf"
|
||||
owner: "{{ config_owner }}"
|
||||
group: "{{ config_owner }}"
|
||||
mode: '0644'
|
||||
when: home_dir != '/'
|
||||
|
||||
mode: '0644'
|
||||
Reference in New Issue
Block a user